ZENOTME commented on PR #349: URL: https://github.com/apache/iceberg-rust/pull/349#issuecomment-2108162712
Hi, I have tried to fix this PR. Some things may not be fixed well now: 1. https://github.com/apache/iceberg-rust/pull/349#discussion_r1580444775 I'm not sure whether my understanding is correct 2. todo, we can do them in later PR: - https://github.com/apache/iceberg-rust/pull/349#discussion_r1580446821 - https://github.com/apache/iceberg-rust/pull/349#discussion_r1579420662 3. https://github.com/apache/iceberg-rust/pull/349#discussion_r1580571634 Please let me know if there are other things I miss and need to fix. cc @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
