Fokko commented on code in PR #349:
URL: https://github.com/apache/iceberg-rust/pull/349#discussion_r1611263732
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -260,6 +279,29 @@ impl<'de> Deserialize<'de> for PrimitiveType {
}
}
+impl PrimitiveType {
+ /// Check whether literal is compatible with the type.
+ pub fn compatible(&self, literal: &PrimitiveLiteral) -> bool {
+ matches!(
+ (self, literal),
+ (PrimitiveType::Boolean, PrimitiveLiteral::Boolean(_))
+ | (PrimitiveType::Int, PrimitiveLiteral::Int(_))
+ | (PrimitiveType::Long, PrimitiveLiteral::Long(_))
+ | (PrimitiveType::Float, PrimitiveLiteral::Float(_))
+ | (PrimitiveType::Double, PrimitiveLiteral::Double(_))
+ | (PrimitiveType::Decimal { .. }, PrimitiveLiteral::Decimal(_))
Review Comment:
If we decide to go this route, we probably also want to check the
precision/scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
