nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600577909


##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -326,15 +313,17 @@ private void verifyProjectIdColumn(Iterable<Record> 
results) {
         Lists.transform(file3FirstSnapshotRecords, record -> (Long) 
record.getField("id")));
 
     results.forEach(
-        record -> Assert.assertEquals("Record should have one projected 
field", 1, record.size()));
-
-    Assert.assertEquals(
-        "Should project only id columns",
-        expected,
-        Sets.newHashSet(transform(results, record -> (Long) 
record.getField("id"))));
+        record -> Assertions.assertThat(record.size()).as("Record should have 
one projected field")

Review Comment:
   should be using `hasSize()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to