nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1600580363
##########
data/src/test/java/org/apache/iceberg/data/avro/TestSingleMessageEncoding.java:
##########
@@ -87,8 +86,10 @@ public void testByteBufferRoundTrip() throws Exception {
Record copy = decoder.decode(encoder.encode(V2_RECORDS.get(0)));
- Assert.assertTrue("Copy should not be the same object", copy !=
V2_RECORDS.get(0));
- Assert.assertEquals("Record should be identical after round-trip",
V2_RECORDS.get(0), copy);
+ Assertions.assertThat(copy).as("Copy should not be the same
object").isNotSameAs(V2_RECORDS.get(0));
+ Assertions.assertThat(V2_RECORDS.get(0))
+ .as("Record should be identical after round-trip")
+ .isEqualTo(copy);
Review Comment:
`V2_RECORDS.get(0)` is the expected and `copy` is the actual, so the
assertion needs to be the other way around here and in a bunch of other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
