RussellSpitzer commented on a change in pull request #1211:
URL: https://github.com/apache/iceberg/pull/1211#discussion_r456013050
##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntry.java
##########
@@ -25,7 +25,7 @@
import static org.apache.iceberg.types.Types.NestedField.optional;
import static org.apache.iceberg.types.Types.NestedField.required;
-interface ManifestEntry<F extends ContentFile<F>> {
+public interface ManifestEntry<F extends ContentFile<F>> {
Review comment:
We could, if it was more palatable, expose a higher level api such as
getAddedFiles, getExistingFiles, .... and so on so that callers don't need to
know this lower level detail. I'm not sure if that is better since you still
basically need to expose the enum values anyway ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
