RussellSpitzer commented on a change in pull request #1211:
URL: https://github.com/apache/iceberg/pull/1211#discussion_r456013690
##########
File path: core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
##########
@@ -152,168 +164,33 @@ private void cleanExpiredSnapshots() {
// 2. Delete any data files that were deleted by those snapshots and are
not in the table
// 3. Delete any manifests that are no longer used by current snapshots
// 4. Delete the manifest lists
+ SnapshotExpirationChanges snapshotExpirationChanges =
+ ExpireSnapshotUtil.getExpiredSnapshots(ops, base);
Review comment:
Good call, I think that makes more sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
