HonahX commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1632638743
##########
pyiceberg/table/__init__.py:
##########
@@ -3735,3 +3894,92 @@ def _determine_partitions(spec: PartitionSpec, schema:
Schema, arrow_table: pa.T
table_partitions: List[TablePartition] =
_get_table_partitions(arrow_table, spec, schema, slice_instructions)
return table_partitions
+
+
+class _ManifestMergeManager:
+ _target_size_bytes: int
+ _min_count_to_merge: int
+ _merge_enabled: bool
+ _snapshot_producer: _MergingSnapshotProducer
+
+ def __init__(
+ self, target_size_bytes: int, min_count_to_merge: int, merge_enabled:
bool, snapshot_producer: _MergingSnapshotProducer
+ ) -> None:
+ self._target_size_bytes = target_size_bytes
+ self._min_count_to_merge = min_count_to_merge
+ self._merge_enabled = merge_enabled
+ self._snapshot_producer = snapshot_producer
+
+ def _group_by_spec(
+ self, first_manifest: ManifestFile, remaining_manifests:
List[ManifestFile]
Review Comment:
Great catch! I simplified it to just take a list of manifests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
