Fokko commented on code in PR #363:
URL: https://github.com/apache/iceberg-python/pull/363#discussion_r1665964062
##########
pyiceberg/table/__init__.py:
##########
@@ -2998,21 +3074,22 @@ def _deleted_entries(self) -> List[ManifestEntry]: ...
@abstractmethod
def _existing_manifests(self) -> List[ManifestFile]: ...
+ def _process_manifests(self, manifests: List[ManifestFile]) ->
List[ManifestFile]:
+ """To perform any post-processing on the manifests before writing them
to the new snapshot."""
+ return manifests
+
def _manifests(self) -> List[ManifestFile]:
def _write_added_manifest() -> List[ManifestFile]:
if self._added_data_files:
- output_file_location = _new_manifest_path(
- location=self._transaction.table_metadata.location, num=0,
commit_uuid=self.commit_uuid
- )
with write_manifest(
format_version=self._transaction.table_metadata.format_version,
spec=self._transaction.table_metadata.spec(),
schema=self._transaction.table_metadata.schema(),
- output_file=self._io.new_output(output_file_location),
+ output_file=self.new_manifest_output(),
Review Comment:
Thanks for digging into this and fixing it 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
