RussellSpitzer commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1633695272
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -140,6 +142,30 @@ public StructType partitionType() {
return lazyPartitionType;
}
+ /**
+ * Returns a struct with TransformID's which match the ID's used in the
Table Metadata. This is
+ * different than the {@link #partitionType()} method which returns a struct
which is guaranteed
+ * not to overlap with column ID's of the table by reassigning ID's.
+ */
+ public StructType rawPartitionType() {
+ if (schema.idsToOriginal().isEmpty()) {
Review Comment:
Is this just the "unpartitioned" case? If so can we condition this on the
schema being empty?
If the case is just idToOriginals.isEmpty, shouldn't that be an error?
Should we always have values there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
