szehon-ho commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1633910150
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -140,6 +142,30 @@ public StructType partitionType() {
return lazyPartitionType;
}
+ /**
+ * Returns a struct with TransformID's which match the ID's used in the
Table Metadata. This is
+ * different than the {@link #partitionType()} method which returns a struct
which is guaranteed
+ * not to overlap with column ID's of the table by reassigning ID's.
+ */
+ public StructType rawPartitionType() {
+ if (schema.idsToOriginal().isEmpty()) {
Review Comment:
Yea this is only for the case that ids are not assigned.
Yea one of the main problems was that the partition field ids are persisted
on file, and so are needed to deserialize the manifest. So this is used in
ManifestReader in that one case. Afterwards, everything in memory is
re-assigned to de-conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
