rdsr commented on a change in pull request #1197: URL: https://github.com/apache/iceberg/pull/1197#discussion_r459249268
########## File path: orc/src/main/java/org/apache/iceberg/orc/OrcRowWriter.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.orc; + +import java.io.IOException; +import org.apache.orc.storage.ql.exec.vector.VectorizedRowBatch; + +/** + * Write data value of a schema. Review comment: nit: maybe reword as .. writes or appends a `row` to Orc's `VectorizedRowBatch` ########## File path: spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcWriter.java ########## @@ -42,7 +42,7 @@ * This class acts as an adaptor from an OrcFileAppender to a * FileAppender<InternalRow>. */ -public class SparkOrcWriter implements OrcValueWriter<InternalRow> { +public class SparkOrcWriter implements OrcRowWriter<InternalRow> { private final Converter[] converters; Review comment: Does it make sense to file a ticket to refactor SparkOrcWriter to utilize similar approach of using `OrchSchemaVisitor`. This could help with reuse of common generic writers defined in `GenericOrcWriters`, similar to how we did in `SparkOrcReaders`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
