openinx commented on a change in pull request #1197:
URL: https://github.com/apache/iceberg/pull/1197#discussion_r459274527
##########
File path: spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcWriter.java
##########
@@ -42,7 +42,7 @@
* This class acts as an adaptor from an OrcFileAppender to a
* FileAppender<InternalRow>.
*/
-public class SparkOrcWriter implements OrcValueWriter<InternalRow> {
+public class SparkOrcWriter implements OrcRowWriter<InternalRow> {
private final Converter[] converters;
Review comment:
Yeah, that's exactly what I plan to do. I've filed an issue to address
this thing. https://github.com/apache/iceberg/issues/1236. Thanks for
bringing it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
