nastra commented on code in PR #10663:
URL: https://github.com/apache/iceberg/pull/10663#discussion_r1670271832
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/reader/ReaderFunctionTestBase.java:
##########
@@ -49,19 +52,18 @@ public static Object[][] parameters() {
};
}
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new
TemporaryFolder();
+ @TempDir protected Path temporaryFolder;
protected abstract ReaderFunction<T> readerFunction();
protected abstract void assertRecords(List<Record> expected, List<T> actual,
Schema schema);
- private final FileFormat fileFormat;
- private final GenericAppenderFactory appenderFactory;
+ @Parameter(index = 0)
+ private FileFormat fileFormat;
- public ReaderFunctionTestBase(FileFormat fileFormat) {
- this.fileFormat = fileFormat;
- this.appenderFactory = new GenericAppenderFactory(TestFixtures.SCHEMA);
- }
+ @Parameter(index = 1)
Review Comment:
it seems weird that this is a parameter that isn't actually used in the list
of parameters in this class. I think this also needs to be fixed for Flink 1.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
