nastra commented on code in PR #10663:
URL: https://github.com/apache/iceberg/pull/10663#discussion_r1671578653
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestArrayPoolDataIteratorBatcherRowData.java:
##########
@@ -36,66 +40,61 @@
import org.apache.iceberg.flink.TestHelpers;
import org.apache.iceberg.flink.source.DataIterator;
import org.apache.iceberg.io.CloseableIterator;
-import org.junit.Assert;
-import org.junit.ClassRule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
public class TestArrayPoolDataIteratorBatcherRowData {
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new
TemporaryFolder();
- private static final FileFormat fileFormat = FileFormat.PARQUET;
-
- private final GenericAppenderFactory appenderFactory;
- private final DataIteratorBatcher<RowData> batcher;
-
- public TestArrayPoolDataIteratorBatcherRowData() {
- Configuration config = new Configuration();
- // set array pool size to 1
- config.set(SourceReaderOptions.ELEMENT_QUEUE_CAPACITY, 1);
- // set batch array size to 2
- config.set(FlinkConfigOptions.SOURCE_READER_FETCH_BATCH_RECORD_COUNT, 2);
- this.batcher =
- new ArrayPoolDataIteratorBatcher<>(config, new
RowDataRecordFactory(TestFixtures.ROW_TYPE));
- this.appenderFactory = new GenericAppenderFactory(TestFixtures.SCHEMA);
- }
+ @TempDir protected Path temporaryFolder;
+ private static final FileFormat FILE_FORMAT = FileFormat.PARQUET;
+ private final Configuration config =
+ new Configuration()
+ .set(SourceReaderOptions.ELEMENT_QUEUE_CAPACITY, 1)
+ .set(FlinkConfigOptions.SOURCE_READER_FETCH_BATCH_RECORD_COUNT, 2);
+
+ private final GenericAppenderFactory appenderFactory =
+ new GenericAppenderFactory(TestFixtures.SCHEMA);;
Review Comment:
```suggestion
new GenericAppenderFactory(TestFixtures.SCHEMA);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
