findepi commented on code in PR #10673:
URL: https://github.com/apache/iceberg/pull/10673#discussion_r1673751208
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -284,6 +284,10 @@
<property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
<message key="name.invalidPattern" value="Member name ''{0}'' must
match pattern ''{1}''."/>
</module>
+ <module name="ConstantName">
+ <property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>
+ <message key="name.invalidPattern" value="Constant name ''{0}''
must match pattern ''{1}''."/>
Review Comment:
Both messages are clear and actionable. My preference would be not to add
configuration that is not needed.
I noticed we do set this for other checks, and I believe we can remove those
other configurations too, in places where they do not add much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
