attilakreiner commented on code in PR #10673:
URL: https://github.com/apache/iceberg/pull/10673#discussion_r1673906437
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -284,6 +284,10 @@
<property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
<message key="name.invalidPattern" value="Member name ''{0}'' must
match pattern ''{1}''."/>
</module>
+ <module name="ConstantName">
+ <property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>
Review Comment:
@nastra, yep, same thought here, hence the spin-off draft PR.
In this PR the definition I used is this (this is the current state right
now):
`<property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>`
the default you linked is this:
`<property name="format" ="^log(ger)?$|^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>`
So the only difference is I removed the first part that allows for the
lowercase `log(ger)` as this codebase doesn't use it, so it was redundant.
Also we have the custom message in place to be consistent with the rest of
the definitions for now.
Pls LMK if this is all good as it right now or we need some changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
