c-thiel commented on code in PR #505:
URL: https://github.com/apache/iceberg-rust/pull/505#discussion_r1696582866
##########
crates/iceberg/src/io/storage_s3.rs:
##########
@@ -32,9 +33,53 @@ pub const S3_ACCESS_KEY_ID: &str = "s3.access-key-id";
pub const S3_SECRET_ACCESS_KEY: &str = "s3.secret-access-key";
/// S3 region.
pub const S3_REGION: &str = "s3.region";
+/// S3 Path Style Access.
+pub const S3_PATH_STYLE_ACCESS: &str = "s3.path-style-access";
+/// S3 Server Side Encryption Type.
+pub const S3_SSE_TYPE: &str = "s3.sse.type";
+/// S3 Server Side Encryption Key.
+/// If S3 encryption type is kms, input is a KMS Key ID.
+/// In case this property is not set, default key "aws/s3" is used.
+/// If encryption type is custom, input is a custom base-64 AES256 symmetric
key.
+pub const S3_SSE_KEY: &str = "s3.sse.key";
+/// S3 Server Side Encryption MD5.
+pub const S3_SSE_MD5: &str = "s3.sse.md5";
+
+/// S3 Server Side Encryption types
+#[derive(Debug, Clone, PartialEq, Hash)]
+pub enum S3SSEType {
+ /// S3 SSE-C, using customer managed keys.
https://docs.aws.amazon.com/AmazonS3/latest/dev/ServerSideEncryptionCustomerKeys.html
+ Custom,
+ /// S3 SSE KMS, either using default or custom KMS key.
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
+ KMS,
+ /// S3 SSE-S3 encryption (S3 managed keys).
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
+ S3,
+ /// No Server Side Encryption
+ None,
+}
+
+impl FromStr for S3SSEType {
Review Comment:
Addressed in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
