Xuanwo commented on PR #505:
URL: https://github.com/apache/iceberg-rust/pull/505#issuecomment-2257833570

   > 1. Everything around soft-deletes (`s3.delete.*`)
   
   The Iceberg Java FileIO implements soft deletes using `PutObjectTags` and a 
user-configured lifecycle to support it. Deleted objects can still be scanned 
or listed because S3 does not recognize the concept of soft deletes. While it's 
possible for OpenDAL to support this, I doubt its usefulness.
   
   I personally think adopting the object version is a better idea for that.
   
   > 2. Remote signing ("s3.remote-signing-enabled")
   
   I checked how iceberg-java implemetns `remote-signing`:
   
   
https://github.com/apache/iceberg/blob/f7585932a6d89b04c0d45b5f9dfe6f45483efd0b/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java#L65-L76
   
   It seems we need to implement this signer in iceberg-rust and pass it as a 
customized signer to opendal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to