amitgilad3 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1702205353
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##########
@@ -134,6 +138,21 @@ private RewriteDataFiles checkAndApplyFilter(
return action;
}
+ private RewriteDataFiles checkAndApplyBranch(
+ Table table, Identifier ident, RewriteDataFiles action) {
+ String branchIdent = Spark3Util.extractBranch(ident);
+ if (branchIdent != null) {
+ return action.targetBranch(branchIdent);
+ }
+ SparkWriteConf writeConf = new SparkWriteConf(spark(), table,
Maps.newHashMap());
Review Comment:
Hey @szehon-ho - im continuing the great work @zinking did and want to
finish the pr(first time contributing) ,
i changed the function and was wondring if you think that SparkWriteConf
should receive branch as a new third argument or should i be in the
Map<String, String> writeOptions ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
