amitgilad3 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1702257014
##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -171,6 +171,17 @@ default RewriteDataFiles zOrder(String... columns) {
*/
RewriteDataFiles filter(Expression expression);
+ /**
+ * A user provided branch which the rewrite happens on the target branch can
also be controlled
+ * via WAP(write-audit-publish)
+ *
+ * @param branch the branch where the rewrite happens
+ * @return this for chaining
Review Comment:
i also think we should leave it to match all other returns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
