RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793770367
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##########
@@ -108,14 +108,14 @@ public static Object[][] parameters() {
SparkCatalogConfig.SPARK.implementation(),
SparkCatalogConfig.SPARK.properties(),
PARQUET,
- ImmutableMap.of(COMPRESSION_CODEC, "zstd", COMPRESSION_LEVEL, "1")
Review Comment:
nit: We are only partially alphabetizing here
This is the kind of thing I do love but it should be
gzip
snappy
zstd
I would probably just skip this change for now and do it in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
