RussellSpitzer commented on code in PR #11257:
URL: https://github.com/apache/iceberg/pull/11257#discussion_r1793776491
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java:
##########
@@ -302,4 +303,12 @@ private <T> MemoryStream<T> newMemoryStream(int id,
SQLContext sqlContext, Encod
private <T> void send(List<T> records, MemoryStream<T> stream) {
stream.addData(JavaConverters.asScalaBuffer(records));
}
+
+ private void deleteFileAndCrc(File file) throws IOException {
+ File crcFile = new File(file.getParent(), "." + file.getName() + ".crc");
Review Comment:
Are you sure the "." +file.getName is correct here?
Could we use
```new File(file.getAbsolutePath + ".crc")```
Also under what cases should crcFile not exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
