aokolnychyi commented on code in PR #11495:
URL: https://github.com/apache/iceberg/pull/11495#discussion_r1836681746
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -643,6 +666,22 @@ protected DataFile newDataFile(String partitionPath) {
.build();
}
+ protected DeleteFile fileADeletes() {
+ return formatVersion >= 3 ? FILE_A_DV : FILE_A_DELETES;
+ }
+
+ protected DeleteFile fileBDeletes() {
+ return formatVersion >= 3 ? FILE_B_DV : FILE_B_DELETES;
+ }
+
+ protected DeleteFile newDeletes(DataFile dataFile) {
Review Comment:
Other `newDeleteFile` methods below return V2 position deletes, so I wanted
to differentiate.
I am OK renaming too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
