aokolnychyi commented on code in PR #11495:
URL: https://github.com/apache/iceberg/pull/11495#discussion_r1837091098
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##########
@@ -956,6 +956,62 @@ public void
testRewriteLargeDeleteManifestsPartitionedTable() throws IOException
assertThat(deleteManifests).hasSizeGreaterThanOrEqualTo(2);
}
+ @TestTemplate
+ public void testUpgradeToV3() throws IOException {
Review Comment:
I agree the name is too generic. I did cover adding a DV to an existing file
with positional delete in a previous PR
[here](https://github.com/apache/iceberg/pull/11467/files#diff-f7cf300e48afd586e158fba64c058d30d14d37b3e96739d6cca23758ee444593R633)).
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##########
@@ -956,6 +956,62 @@ public void
testRewriteLargeDeleteManifestsPartitionedTable() throws IOException
assertThat(deleteManifests).hasSizeGreaterThanOrEqualTo(2);
}
+ @TestTemplate
+ public void testUpgradeToV3() throws IOException {
Review Comment:
I agree the name is too generic, I'll update. I did cover adding a DV to an
existing file with positional delete in a previous PR
[here](https://github.com/apache/iceberg/pull/11467/files#diff-f7cf300e48afd586e158fba64c058d30d14d37b3e96739d6cca23758ee444593R633)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
