pvary commented on code in PR #11662:
URL: https://github.com/apache/iceberg/pull/11662#discussion_r1860563456
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SortKeySerializer.java:
##########
@@ -124,6 +124,13 @@ public void serialize(SortKey record, DataOutputView
target) throws IOException
for (int i = 0; i < size; ++i) {
int fieldId = transformedFields[i].fieldId();
Type.TypeID typeId = transformedFields[i].type().typeId();
+ Object value = record.get(i, Object.class);
+ if (value == null) {
+ target.writeBoolean(true);
+ continue;
+ } else {
+ target.writeBoolean(false);
+ }
Review Comment:
nit: newline after closing a block and starting another statement
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/SortKeySerializer.java:
##########
@@ -192,6 +199,11 @@ public SortKey deserialize(SortKey reuse, DataInputView
source) throws IOExcepti
reuse.size(),
size);
for (int i = 0; i < size; ++i) {
+ boolean isNull = source.readBoolean();
+ if (isNull) {
+ reuse.set(i, null);
+ continue;
+ }
Review Comment:
nit: newline after closing a block and starting another statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
