pvary commented on code in PR #11662:
URL: https://github.com/apache/iceberg/pull/11662#discussion_r1860967334
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestDataStatisticsCoordinator.java:
##########
@@ -152,6 +152,80 @@ public void testDataStatisticsEventHandling(StatisticsType
type) throws Exceptio
}
}
+ @ParameterizedTest
+ @EnumSource(StatisticsType.class)
+ public void testDataStatisticsEventHandlingWithNullValue(StatisticsType
type) throws Exception {
+ try (DataStatisticsCoordinator dataStatisticsCoordinator =
createCoordinator(type)) {
+ dataStatisticsCoordinator.start();
+ tasksReady(dataStatisticsCoordinator);
+
+ SortKey NullSortKey = Fixtures.SORT_KEY.copy();
Review Comment:
nit: The variable name should start with small letter
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestDataStatisticsCoordinator.java:
##########
@@ -152,6 +152,80 @@ public void testDataStatisticsEventHandling(StatisticsType
type) throws Exceptio
}
}
+ @ParameterizedTest
+ @EnumSource(StatisticsType.class)
+ public void testDataStatisticsEventHandlingWithNullValue(StatisticsType
type) throws Exception {
+ try (DataStatisticsCoordinator dataStatisticsCoordinator =
createCoordinator(type)) {
+ dataStatisticsCoordinator.start();
+ tasksReady(dataStatisticsCoordinator);
+
+ SortKey NullSortKey = Fixtures.SORT_KEY.copy();
Review Comment:
nit: The variable name should start with lower case letter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
