kevinjqliu commented on code in PR #1423:
URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1884193700
##########
tests/table/test_init.py:
##########
@@ -310,6 +310,19 @@ def test_table_scan_row_filter(table_v2: Table) -> None:
assert scan.filter(EqualTo("x", 10)).filter(In("y", (10, 11))).row_filter
== And(EqualTo("x", 10), In("y", (10, 11)))
+def test_table_scan_partition_filters_case_sensitive(table_v2: Table) -> None:
Review Comment:
nit: the goal of this test is to show that case sensitive scan works. i
think a more readable test can be something like
1. assert data exists for `row_filter=EqualTo("X", 10)`
2. assert case sensitive scan for `row_filter=EqualTo("X", 10)` returns the
same data
3. assert case insensitive scan for `row_filter=EqualTo("X", 10)` and
`row_filter=EqualTo("x", 10)` also returns the same data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
