Fokko commented on code in PR #1423:
URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1885721293
##########
pyiceberg/table/__init__.py:
##########
@@ -470,17 +470,23 @@ def overwrite(
for data_file in data_files:
update_snapshot.append_data_file(data_file)
- def delete(self, delete_filter: Union[str, BooleanExpression],
snapshot_properties: Dict[str, str] = EMPTY_DICT) -> None:
+ def delete(
+ self,
+ delete_filter: Union[str, BooleanExpression],
+ case_sensitive: bool = True,
Review Comment:
Can we add this one to the end?
##########
pyiceberg/table/__init__.py:
##########
@@ -987,6 +993,7 @@ def overwrite(
self,
df: pa.Table,
overwrite_filter: Union[BooleanExpression, str] = ALWAYS_TRUE,
+ case_sensitive: bool = True,
Review Comment:
Same here, let's add this to the end to avoid breaking folks who use
positional arguments to pass in properties.
##########
pyiceberg/table/__init__.py:
##########
@@ -421,6 +419,7 @@ def overwrite(
self,
df: pa.Table,
overwrite_filter: Union[BooleanExpression, str] = ALWAYS_TRUE,
+ case_sensitive: bool = True,
Review Comment:
Also, this one should go to the very end. I'll stop commenting on this :)
##########
pyiceberg/table/__init__.py:
##########
@@ -268,12 +268,10 @@ def _apply(self, updates: Tuple[TableUpdate, ...],
requirements: Tuple[TableRequ
return self
- def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE)
-> DataScan:
+ def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE,
case_sensitive: bool = True) -> DataScan:
Review Comment:
I would leave this argument out since the `TableScan` is more like a builder
pattern: `.scan().with_case_sensitive()`. Also, it doesn't allow to pass in a
filter, columns, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
