xxchan commented on PR #824: URL: https://github.com/apache/iceberg-rust/pull/824#issuecomment-2556160311
> I'm not a big fan of checking in Cargo.lock as it's an antipattern for library Just FYI that it's not considered an antipattern any more https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html And e.g., opendal has it: https://github.com/apache/opendal/blob/main/core/Cargo.lock I'm OK with both though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
