sdd commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1912774587
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -351,19 +383,26 @@ impl ArrowReader {
true
});
- if column_map.len() != field_ids.len() {
+ if column_map.len() != leaf_field_ids.len() {
+ let miss_field = leaf_field_ids
Review Comment:
This var should be called `missing_fields` I think, and similarly in the
associated `with_context` (I love that these contexts are getting added by the
way 😄 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
