liurenjie1024 commented on code in PR #882:
URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1920988957
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field
name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
Review Comment:
Why we need to make them public?
##########
crates/integration_tests/tests/scan_all_type.rs:
##########
Review Comment:
Could we add some more test cases? I think we are missing handling the case
in https://github.com/apache/iceberg-rust/issues/405
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -226,8 +228,10 @@ pub enum PrimitiveType {
/// Timestamp in microsecond precision, with timezone
Timestamptz,
/// Timestamp in nanosecond precision, without timezone
+ #[serde(rename = "timestamp_ns")]
Review Comment:
This is correct, but why is it related with reading complex type?
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -43,7 +43,9 @@ use crate::spec::{
use crate::{Error, ErrorKind};
/// When iceberg map type convert to Arrow map type, the default map field
name is "key_value".
-pub(crate) const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+pub const DEFAULT_MAP_FIELD_NAME: &str = "key_value";
+/// UTC time zone for Arrow timestamp type.
+pub const UTC_TIME_ZONE: &str = "+00:00";
Review Comment:
Ditto.
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -36,9 +36,11 @@ use crate::spec::datatypes::_decimal::{MAX_PRECISION,
REQUIRED_LENGTH};
use crate::spec::PrimitiveLiteral;
/// Field name for list type.
-pub(crate) const LIST_FILED_NAME: &str = "element";
-pub(crate) const MAP_KEY_FIELD_NAME: &str = "key";
-pub(crate) const MAP_VALUE_FIELD_NAME: &str = "value";
+pub const LIST_FIELD_NAME: &str = "element";
+/// Field name for map type's key.
+pub const MAP_KEY_FIELD_NAME: &str = "key";
+/// Field name for map type's value.
+pub const MAP_VALUE_FIELD_NAME: &str = "value";
Review Comment:
Same question why we need to make them public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
