rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917299961
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -76,6 +67,31 @@ protected ParquetValueReader<T> createReader(
protected abstract ParquetValueReader<T> createStructReader(
List<Type> types, List<ParquetValueReader<?>> fieldReaders,
Types.StructType structType);
+ protected ParquetValueReaders.PrimitiveReader<?>
fixedReader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected ParquetValueReaders.PrimitiveReader<?>
int96Reader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected Optional<ParquetValueReader<?>> dateReader(ColumnDescriptor desc) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> timeReader(ColumnDescriptor desc,
TimeUnit unit) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> timestampReader(
+ ColumnDescriptor desc, TimeUnit unit, boolean isAdjustedToUTC) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> uuidReader(ColumnDescriptor desc) {
Review Comment:
Why is there a factory method for UUID? Both uses of this class have the
same representation so a new method is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
