rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1917325058
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##########
@@ -330,6 +382,17 @@ public void write(int repetitionLevel, CharSequence value)
{
}
}
+ private static class UUIDWriter extends PrimitiveWriter<UUID> {
+ private UUIDWriter(ColumnDescriptor desc) {
+ super(desc);
+ }
+
+ @Override
+ public void write(int repetitionLevel, UUID value) {
+ column.writeBinary(repetitionLevel,
Binary.fromReusedByteArray(UUIDUtil.convert(value)));
Review Comment:
The byte array passed here is allocated, not reused. It probably should be
reused, like the one in Spark's writers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
