mrcnc commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1918901118
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
"s3n", S3_FILE_IO_IMPL,
"gs", GCS_FILE_IO_IMPL,
"abfs", ADLS_FILE_IO_IMPL,
- "abfss", ADLS_FILE_IO_IMPL);
+ "abfss", ADLS_FILE_IO_IMPL,
+ "wasb", ADLS_FILE_IO_IMPL,
+ "wasbs", ADLS_FILE_IO_IMPL);
Review Comment:
I see the [JdbcCatalog uses HadoopFileIO by
default](https://github.com/apache/iceberg/blob/91a1505d09cebcd1d088ac53cd42732c343883de/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L129-L131)
so it wouldn't affect these users, but it would affect the [REST Catalog which
defaults to
ResolvingFileIO](https://github.com/apache/iceberg/blob/91a1505d09cebcd1d088ac53cd42732c343883de/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L115).
Maybe this is ok but needs to be added to release notes for 1.8.0? If not,
we can remove it for now or activate this behavior explicitly with another
setting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
