amogh-jahagirdar commented on code in PR #11830:
URL: https://github.com/apache/iceberg/pull/11830#discussion_r1919521749
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -62,7 +62,9 @@ public class ResolvingFileIO implements HadoopConfigurable,
DelegateFileIO {
"s3n", S3_FILE_IO_IMPL,
"gs", GCS_FILE_IO_IMPL,
"abfs", ADLS_FILE_IO_IMPL,
- "abfss", ADLS_FILE_IO_IMPL);
+ "abfss", ADLS_FILE_IO_IMPL,
+ "wasb", ADLS_FILE_IO_IMPL,
+ "wasbs", ADLS_FILE_IO_IMPL);
Review Comment:
I think it's actually important to update the mapping (so imo what's here is
correct). I think ResolvingFileIO should always only fallback to HadoopFileIO
as a last resort, and in this case we do want wasb/wasbs to resolve to ADLS so
that any custom integrations that happens in Iceberg in the ADLSFileIO
implementation can be taken advantage of. At the same time we should document
it.
In general, I feel like we shouldn't design for the case where a user relies
on ResolvingFileIO's fallback HadoopFileIO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
