nastra commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1922256104
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -337,27 +337,20 @@ public void testCatalogBasicBearerToken() {
// the bearer token should be used for all interactions
Mockito.verify(adapter)
.execute(
- eq(HTTPMethod.GET),
- eq("v1/config"),
- any(),
- any(),
+ reqMatcher(HTTPMethod.GET, "v1/config", catalogHeaders),
eq(ConfigResponse.class),
- eq(catalogHeaders),
+ any(),
any());
Mockito.verify(adapter)
.execute(
- eq(HTTPMethod.HEAD),
- eq("v1/namespaces/ns/tables/table"),
+ reqMatcher(HTTPMethod.HEAD, "v1/namespaces/ns/tables/table",
catalogHeaders),
any(),
any(),
- any(),
- eq(catalogHeaders),
any());
}
@Test
public void testCatalogCredentialNoOauth2ServerUri() {
- Map<String, String> emptyHeaders = ImmutableMap.of();
Review Comment:
nit: we might want to consider keeping this so that it's clearer that empty
headers are expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
