nastra commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1922265637
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2122,23 +1948,18 @@ public void
testCatalogTokenRefreshDisabledWithCredential(String oauth2ServerUri
"scope",
"catalog");
Mockito.verify(adapter)
- .execute(
- eq(HTTPMethod.POST),
+ .postForm(
eq(oauth2ServerUri),
- any(),
- Mockito.argThat(fetchTokenFromCredential::equals),
+ argThat(fetchTokenFromCredential::equals),
eq(OAuthTokenResponse.class),
- eq(ImmutableMap.of()),
+ anyMap(),
Review Comment:
should this rather verify that this should be an empty map instead of any
map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
