Fokko commented on code in PR #1539:
URL: https://github.com/apache/iceberg-python/pull/1539#discussion_r1923422826
##########
pyiceberg/partitioning.py:
##########
@@ -413,7 +414,9 @@ def partition_record_value(partition_field: PartitionField,
value: Any, schema:
the final partition record value.
"""
iceberg_type =
schema.find_field(name_or_id=partition_field.source_id).field_type
- iceberg_typed_value = _to_partition_representation(iceberg_type, value)
+ if not isinstance(value, int):
+ # When adding files, it can be that we still need to convert from
logical types to physical types
+ iceberg_typed_value = _to_partition_representation(iceberg_type, value)
Review Comment:
Ah, of course. We want to know the output tuples after the transform, so
omitting the transformation is not possible. I think we could do a follow-up PR
where we split out the logic for the write path, and the `add-files` path.
Since after this PR, this is not needed when doing partitioned writes, we just
need it to preprocess when importing partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
