rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1927925802
##########
api/src/test/java/org/apache/iceberg/types/TestTypeUtil.java:
##########
@@ -24,38 +24,43 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import java.util.Set;
+import java.util.stream.Stream;
import org.apache.iceberg.Schema;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
-import org.apache.iceberg.types.Types.IntegerType;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
public class TestTypeUtil {
- @Test
- public void testReassignIdsDuplicateColumns() {
+ private static Stream<Arguments> testTypes() {
+ return Stream.of(Arguments.of(Types.IntegerType.get()),
Arguments.of(Types.VariantType.get()));
+ }
+
+ @ParameterizedTest
+ @MethodSource("testTypes")
+ public void testReassignIdsDuplicateColumns(Type testType) {
Review Comment:
When updating existing tests, it is better to leave tests alone when they
are testing behavior that is not relevant to what you're changing. In this
case, the behavior being tested is not related to the type of these columns, it
is that the columns duplicate one another.
It is typically a red flag for me to see updates to existing tests like
this. When you're adding new behavior, think about what needs to be tested. For
variant, this needs to test that variant columns are preserved (not removed,
skipped, or replaced with `null`) and are reassigned new IDs. It does not need
to test _how_ the IDs are assigned or that ID assignment is case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
