rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1927936162
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -108,19 +121,19 @@ public void testUpgradeFormatVersionFromJson() {
}
/** AddSchema * */
- @Test
- public void testAddSchemaFromJson() {
+ @ParameterizedTest
+ @MethodSource("testSchemas")
Review Comment:
This also abuses existing test cases to test different behavior than was
intended. I think tests should be written directly instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
