dttung2905 commented on code in PR #274:
URL: https://github.com/apache/iceberg-go/pull/274#discussion_r1931276078
##########
catalog/rest/rest_test.go:
##########
@@ -445,6 +445,60 @@ func (r *RestCatalogSuite) TestCreateNamespace200() {
r.Require().NoError(cat.CreateNamespace(context.Background(),
catalog.ToIdentifier("leden"), nil))
}
+func (r *RestCatalogSuite) TestCheckNamespaceExists204() {
+ r.mux.HandleFunc("/v1/namespaces/leden", func(w http.ResponseWriter,
req *http.Request) {
+ r.Require().Equal(http.MethodGet, req.Method)
Review Comment:
Hi @kevinjqliu , thanks so much for the sharp eyes. I see that from the
OpenAPI doc its a method HEAD. I have modified the `CheckNamespaceExists`
method to use `doHead` instead of `doGet` method. :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
