zeroshade commented on code in PR #274:
URL: https://github.com/apache/iceberg-go/pull/274#discussion_r1931290607
##########
catalog/rest/rest.go:
##########
@@ -276,6 +280,10 @@ func doDelete[T any](ctx context.Context, baseURI
*url.URL, path []string, cl *h
return do[T](ctx, http.MethodDelete, baseURI, path, cl, override, true)
}
+func doHead[T any](ctx context.Context, baseURI *url.URL, path []string, cl
*http.Client, override map[int]error) (ret T, err error) {
+ return do[T](ctx, http.MethodHead, baseURI, path, cl, override, true)
+}
Review Comment:
Since a `HEAD` request doesn't have any result/output, shouldn't we just
remove the template param and the `ret` result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
