zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932886875
##########
catalog/glue/glue.go:
##########
@@ -69,7 +69,7 @@ var (
func init() {
catalog.Register("glue", catalog.RegistrarFunc(func(_ string, props
iceberg.Properties) (catalog.Catalog, error) {
- awsConfig, err := toAwsConfig(props)
+ awsConfig, err := toAwsConfig(context.Background(), props)
Review Comment:
should we change the registry to accept a context as part of
`catalog.RegistrarFunc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
