zeroshade commented on code in PR #276:
URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932887872
##########
catalog/rest/rest.go:
##########
@@ -82,7 +82,7 @@ var (
func init() {
reg := catalog.RegistrarFunc(func(name string, p iceberg.Properties)
(catalog.Catalog, error) {
- return newCatalogFromProps(name, p.Get("uri", ""), p)
+ return newCatalogFromProps(context.Background(), name,
p.Get("uri", ""), p)
})
Review Comment:
if we're going to use a context in all of these, then yea we should
definitely change the definition of the registry and `LoadCatalog` to accept a
context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
