wimlewis-amazon commented on issue #11528: URL: https://github.com/apache/iceberg/issues/11528#issuecomment-2632467756
Hmm, from those code snippets, it looks like `enabled` is a _table_ property which enables the behavior, and `branch` is a _spark session_ property that indicates which branch to _read_ (and alternatively disables WAP if it's unset). That's a little weird (shouldn't at least one of those be a _write options_ property? And it seems that WAP affects the behavior of table read as well, which isn't what I would naively expect, although from the PR discussions I can kind of see the idea.) Digging through git-blame, I found a bunch of discussion, in PRs #6651, #6965, which references these behaviors but it's still not clear what the final intended behavior is — what I should expect as a user of the spark api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
