rodrigc commented on issue #11528: URL: https://github.com/apache/iceberg/issues/11528#issuecomment-2632499136
@wimlewis-amazon my understanding is that: 1. `write.wap.enabled` is a table property, and must be set on the table in order to do WAP 2. `spark.wap.branch` is a SQL conf property that specifies the name of the branch Looking at the code, it looks like you need to have the table property *and* the SQL conf property set in order to do WAP. This lines up with the example in the docs here: https://iceberg.apache.org/docs/latest/branching/#audit-branch Originally I looked at the example in the docs, and didn't really understand why there was a table property and an SQL conf property for WAP. Looking at the code snippets above improved my understanding. But I admit, I find this a bit confusing as an end-user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
