zeroshade commented on code in PR #290:
URL: https://github.com/apache/iceberg-go/pull/290#discussion_r1949747930
##########
catalog/rest/rest.go:
##########
@@ -989,3 +989,54 @@ func (r *Catalog) CheckTableExists(ctx context.Context,
identifier table.Identif
}
return true, nil
}
+
+func (r *Catalog) ListViews(ctx context.Context, namespace table.Identifier)
([]table.Identifier, error) {
+ if err := checkValidNamespace(namespace); err != nil {
+ return nil, err
+ }
+
+ ns := strings.Join(namespace, namespaceSeparator)
+ path := []string{"namespaces", ns, "views"}
+
+ type resp struct {
+ Identifiers []identifier `json:"identifiers"`
+ }
Review Comment:
How in-depth / complex would adding it be in this PR?
This PR is currently pretty small so far so as long as adding the handling
of `next-page-token` isn't a large amount of code, it's probably better to
implement it here and fix `ListTables` rather than do it as a separate PR. I
don't think it would be a very large or complex change to add here, but could
be wrong.
If it ends up being pretty complex and large to add it here then I'm fine
having it implemented in a separate PR.
Give it a try and let me know if it starts spiraling into a significantly
large change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
