kevinjqliu commented on code in PR #290:
URL: https://github.com/apache/iceberg-go/pull/290#discussion_r1953329429
##########
catalog/rest/rest.go:
##########
@@ -989,3 +989,54 @@ func (r *Catalog) CheckTableExists(ctx context.Context,
identifier table.Identif
}
return true, nil
}
+
+func (r *Catalog) ListViews(ctx context.Context, namespace table.Identifier)
([]table.Identifier, error) {
+ if err := checkValidNamespace(namespace); err != nil {
+ return nil, err
+ }
+
+ ns := strings.Join(namespace, namespaceSeparator)
+ path := []string{"namespaces", ns, "views"}
+
+ type resp struct {
+ Identifiers []identifier `json:"identifiers"`
+ }
Review Comment:
i dont think pyiceberg's rest client paginates at all
https://github.com/apache/iceberg-python/blob/8fcdc951f0959ee2d7e5b9d3057f4b07afd7cdcf/pyiceberg/catalog/rest.py#L737-L746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
