nastra commented on code in PR #12335:
URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961559890
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -58,71 +59,73 @@ public void missingFields() {
@Test
public void roundTripSerde() {
- String uuid = "386b9f01-002b-4d8c-b77f-42c3fd3b7c9b";
- TableMetadata metadata =
- TableMetadata.buildFromEmpty()
- .assignUUID(uuid)
- .setLocation("location")
- .setCurrentSchema(
- new Schema(Types.NestedField.required(1, "x",
Types.LongType.get())), 1)
- .addPartitionSpec(PartitionSpec.unpartitioned())
- .addSortOrder(SortOrder.unsorted())
- .discardChanges()
- .withMetadataLocation("metadata-location")
- .build();
+ for (int formatVersion : Arrays.asList(2, 3)) {
Review Comment:
it's probably good to annotate the test with `@ParameterizedTest` and pass
the format version as an argument. This makes it also easier to debug in case
it fails with one format version but not with the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
