nastra commented on code in PR #12335:
URL: https://github.com/apache/iceberg/pull/12335#discussion_r1961979564
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -56,11 +59,14 @@ public void missingFields() {
.hasMessage("Cannot parse missing field: metadata");
}
- @Test
- public void roundTripSerde() {
+ private static int[] tableVersions = IntStream.range(2, 3).toArray();
+
+ @ParameterizedTest
+ @FieldSource("tableVersions")
Review Comment:
having `@ValueSource(ints = {2, 3})` is probably easier here than having to
define a separate field for the input params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
